Skip to content

Update @typescript-eslint/parser and @typescript-eslint/eslint-plugin#30808

Closed
Bibazavr wants to merge 2 commits into
facebook:mainfrom
Bibazavr:fix/update-ts-eslint-into-eslint-config-rn-community
Closed

Update @typescript-eslint/parser and @typescript-eslint/eslint-plugin#30808
Bibazavr wants to merge 2 commits into
facebook:mainfrom
Bibazavr:fix/update-ts-eslint-into-eslint-config-rn-community

Conversation

@Bibazavr

Copy link
Copy Markdown

Description

This updates needs for use new features from typescript

(like optional proposing and etc)

Without this update you will get errors "Expression expected" while write something like value?.title or (data ?? []).map(...)

React Native version: latest

Steps To Reproduce

  1. create react-native app with typescript
  2. configure eslint with @react-native-community/eslint-config into .eslintrc.* extends
  3. write some thing like: value?.name into your project

Expected Results

Expected - no error while eslit parsing file with some thing like: value?.name

Snack, code example, screenshot, or link to a repository:

https://github.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#400-2020-08-31

Summary

I want use latest features from typescript into my project when i use @react-native-community/eslint-config

Changelog

[General] [Changed] - Update @typescript-eslint/parser and @typescript-eslint/eslint-plugin into @react-native-community/eslint-config

Test Plan

Eslint error before update:

gets error

After update error is gone

## Description

This updates needs for use new features from typescript

(like optional proposing and etc)

Without this update you will get errors "Expression expected" while write something like `value?.title` or `(data ?? []).map(...)`

## React Native version: latest

## Steps To Reproduce

1. create react-native app with typescript
2. configure eslint with @react-native-community/eslint-config into .eslintrc.* extends
3. write some thing like: `value?.name` into your project

## Expected Results

Expected - no error while eslit parsing file with some thing like: `value?.name`

## Snack, code example, screenshot, or link to a repository:

https://github.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#400-2020-08-31
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @Bibazavr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot

analysis-bot commented Jan 28, 2021

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: c760704

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2021
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,887,598 +0
android hermes armeabi-v7a 8,393,195 +0
android hermes x86 9,377,471 +0
android hermes x86_64 9,320,396 +0
android jsc arm64-v8a 10,337,244 +0
android jsc armeabi-v7a 9,825,933 +0
android jsc x86 10,388,620 +0
android jsc x86_64 10,971,784 +0

Base commit: c760704

@Bibazavr

Bibazavr commented Jul 19, 2021

Copy link
Copy Markdown
Author

Closed because another branch was merged

@Bibazavr Bibazavr closed this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants