Consolidate various debug-only flags into flags.h#30988
Closed
JoshuaGross wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D26392518 |
|
Base commit: 6a9bb45 |
Base commit: c760704 |
…line with a title. Use 1 line only, 67 chars or less> Summary: If there's a JS/native crash and the surface is stopped, the ReactRootView could be reused when the surface is restarted (or potentially to show the errors in a logbox; I'm don't think that's possible, but not 100% sure). Regardless, now it will crash in those cases because of T83802049. There's no reason to do that, so just mark the ReactRootView as explicitly unused once the surface is stopped. Changelog: [Internal] Differential Revision: D26469742 fbshipit-source-id: 130b72ad765de44e4729dc37d34b22ad220ec301
Summary: Change lifecycle of stopSurface in a subtle way: mark the surface as stopped in Java first, then in Cxx (currently it happens in Cxx, then Java). This will cause us / allow us to ignore the final mounting instructions for the Surface, which are all irrelevant since they just have to do with View removal. We can rely on GC and `unmountReactApplication` to do all of this for us, and save some CPU cycles on stopSurface. Changelog: [Internal] Differential Revision: D26469741 fbshipit-source-id: 882435c4488e65acf8977dcbf7c10b92c0ac5fbd
Summary: Pull Request resolved: facebook#30988 We have a bunch of flags scattered throughout the codebase with poor hygiene and commenting. Consolidate. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D26392518 fbshipit-source-id: 4d8b1e5189571681468bcee83e53f811e134c156
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D26392518 |
JoshuaGross
force-pushed
the
export-D26392518
branch
from
2dabb4f to
cb21037
Compare
Contributor
|
This pull request has been merged in fb1833e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We have a bunch of flags scattered throughout the codebase with poor hygiene and commenting. Consolidate.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D26392518