Convert SafeAreaView to ES Module#31344
Closed
franzon wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: a15a46c |
lunaleaps
approved these changes
Apr 14, 2021
Contributor
lunaleaps
left a comment
lunaleaps
left a comment
There was a problem hiding this comment.
Other than that, this looks good to me! Thank you for working on this!!
| } | ||
|
|
||
| module.exports = exported; | ||
| export default exported; |
Contributor
There was a problem hiding this comment.
nit: maybe it's clearer to rename this to SafeAreaView?
Contributor
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@lunaleaps merged this pull request in d9a86aa. |
Contributor
|
Thanks @franzon for your contribution! |
Contributor
|
Sorry accidentally clicked "Reopen and comment" lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert SafeAreaView to ES Module (#31330).
Changelog
[General] [Changed] - Converted
SafeAreaViewto ES Module.Test Plan
Tested that
npm testpasses.