removal of textColor from base application theme#31487
Closed
sidverma32 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: 438a4cf |
Contributor
|
@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#31345
The issue to
android/app/src/main/res/values/styles.xml.In the base application theme, there is an explicitly added item
<item name="android:textColor">#000000</item>This leads the
textColorof the app to be black even though the theme is actually DayNight.A permanent fix would be to not have this item added by default when creating a new project, as it is buggy behavior
Changelog
[General] [removed] - line
<item name="android:textColor">#000000</item>in this fileandroid/app/src/main/res/values/styles.xmlfor the inital setupTest Plan
Removing this has fixed the issue for me.