Skip to content

Replace #import in C++ Header with #include#31805

Closed
NickGerleman wants to merge 1 commit into
facebook:masterfrom
NickGerleman:remove-import2
Closed

Replace #import in C++ Header with #include#31805
NickGerleman wants to merge 1 commit into
facebook:masterfrom
NickGerleman:remove-import2

Conversation

@NickGerleman
Copy link
Copy Markdown
Contributor

@NickGerleman NickGerleman commented Jul 2, 2021

Summary

#import is common in Objective C, but is a vendor-specific extension of C++, which breaks MSVC compat. Fix an #import that made its way into C++ code.

Changelog

[Internal] [Fixed] - Replace #import in C++ Header with #include

#import is common in Objective C, but is a vendor-specific extension of C++, which breaks MSVC compat. Fix an #import that made its way into C++ code.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jul 2, 2021
@NickGerleman NickGerleman changed the title Replace #import in C++ Header with #Include Replace #import in C++ Header with #include Jul 2, 2021
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jul 2, 2021

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against f4d68db

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: c06d8d0

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,111,276 -1,929
android hermes armeabi-v7a 8,639,877 -1,922
android hermes x86 9,550,303 -1,935
android hermes x86_64 9,516,739 -1,921
android jsc arm64-v8a 10,754,586 -1,062
android jsc armeabi-v7a 9,674,446 -1,064
android jsc x86 10,789,016 -1,065
android jsc x86_64 11,396,950 -1,061

Base commit: c06d8d0

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache merged this pull request in bf2e1c9.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants