Skip to content

Exclude OpenSSL-Universal flipper dependency from release builds#31938

Closed
janicduplessis wants to merge 2 commits into
facebook:mainfrom
janicduplessis:patch-9
Closed

Exclude OpenSSL-Universal flipper dependency from release builds#31938
janicduplessis wants to merge 2 commits into
facebook:mainfrom
janicduplessis:patch-9

Conversation

@janicduplessis
Copy link
Copy Markdown
Contributor

Summary

Use the same technique as other flipper transitive deps to make sure it is excluded from release builds.

Changelog

[iOS][Fixed] - Exclude OpenSSL-Universal flipper dependency from release builds

Test Plan

Tested in an app that it still builds and works.

@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 2, 2021
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,188,802 +0
android hermes armeabi-v7a 8,714,437 +0
android hermes x86 9,630,667 +0
android hermes x86_64 9,598,413 +0
android jsc arm64-v8a 10,825,165 +0
android jsc armeabi-v7a 9,742,054 +0
android jsc x86 10,862,437 +0
android jsc x86_64 11,471,680 +0

Base commit: 034c6df

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 034c6df

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 12, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@yungsters merged this pull request in c13eb78.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 2, 2021
@janicduplessis janicduplessis deleted the patch-9 branch September 2, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Needs: React Native Team Attention Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants