General Logging Util (stab) class for native errors by sota000 · Pull Request #31998 · facebook/react-native

sota000 · 2021-08-10T18:07:24Z

Summary:
Overall Context: We want to add a way to log errors (e.g. mustfix, warn, etc on the server with stack trace) without crashing the app (e.g. react_native_assert crashes the app).

This diff: I am writing very simple logger functions which will get resolved at build time depending on the platforms/apps.

Changelog: [internal]

Reviewed By: JoshuaGross

Differential Revision: D30174404

Summary: Overall Context: We want to add a way to log errors (e.g. mustfix, warn, etc on the server with stack trace) without crashing the app (e.g. react_native_assert crashes the app). This diff: I am writing very simple logger functions which will get resolved at build time depending on the platforms/apps. Changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D30174404 fbshipit-source-id: 2e095ed7e17f176acee929908abc6d9cf3169591

facebook-github-bot · 2021-08-10T18:07:43Z

This pull request was exported from Phabricator. Differential Revision: D30174404

pull-bot · 2021-08-10T18:16:46Z

	Messages
📖	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖	📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against f495e59

analysis-bot · 2021-08-10T18:40:01Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: d583c2f

analysis-bot · 2021-08-10T18:46:07Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,241,449	+13,334
android	hermes	armeabi-v7a	8,753,358	+2,452
android	hermes	x86	9,683,974	+12,324
android	hermes	x86_64	9,652,838	+12,212
android	jsc	arm64-v8a	10,877,434	+13,342
android	jsc	armeabi-v7a	9,780,602	+2,450
android	jsc	x86	10,915,344	+12,328
android	jsc	x86_64	11,525,728	+12,219

Base commit: d583c2f

Summary: Pull Request resolved: #31998 Overall Context: We want to add a way to log errors (e.g. mustfix, warn, etc on the server with stack trace) without crashing the app (e.g. react_native_assert crashes the app). This diff: I am writing very simple logger functions which will get resolved at build time depending on the platforms/apps. Changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D30174404 fbshipit-source-id: 2e5bc865dd8576c5a758c56e080a1e582a8c3ada

react-native-bot · 2021-08-11T04:35:05Z