refactor: remove DefeaultProps from the DatePickerIOS component

[Fannolo]

Summary

Closes issue #31605.
This is part of a bigger issue that plans to remove defaultProps from class components in order to provide a smoother transition to functional components.

Changelog

[General] [Changed] - Remove defaultProps from the DatePickerIOS Component.
[General] [Test] - Added snapshot test for the new component

Test Plan

Compiled the rn-tester folder to check if the behavior is consistent with the previous versions.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: ff4b336

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,245,595	+14
android	hermes	armeabi-v7a	8,764,641	+14
android	hermes	x86	9,690,601	+4
android	hermes	x86_64	9,657,819	+12
android	jsc	arm64-v8a	10,881,797	+7
android	jsc	armeabi-v7a	9,792,111	+7
android	jsc	x86	10,922,219	+5
android	jsc	x86_64	11,530,938	+2

Base commit: ff4b336

[Fannolo]

@lunaleaps can you assign and review it? Thanks!

[yungsters]

Thanks for your contribution!

Just in case you weren't aware, the change from defaultProps to ?? is not always safe. The value in defaultProps will only be used if a prop value is undefined, whereas ?? will coerce prop values that are either undefined or null.

I manually inspected this case and it does seem safe to switch to ??. In general, I do prefer that we switch to ?? because differences in handling of undefined and null often lead to difficult bugs.

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[Fannolo]

Thanks for your contribution!

Just in case you weren't aware, the change from defaultProps to ?? is not always safe. The value in defaultProps will only be used if a prop value is undefined, whereas ?? will coerce prop values that are either undefined or null.

I manually inspected this case and it does seem safe to switch to ??. In general, I do prefer that we switch to ?? because differences in handling of undefined and null often lead to difficult bugs.

Thank you for your input @yungsters! I didn't know defaultProps will coerce only with undefined values. I chose to use ?? in this case because I didn't see null defined as a type accepted in the prop mode. I will definitely pay more attention in the future when replacing defaultProps with ??.

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@yungsters merged this pull request in 2fb102b.