Skip to content

Setup Gradle Wrapper inside packages/react-native-gradle-plugin/#32140

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D30730145
Closed

Setup Gradle Wrapper inside packages/react-native-gradle-plugin/#32140
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D30730145

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This diff is setting up the Gradle wrapper inside packages/react-native-gradle-plugin/.
Currently the ./gradlew file is missing so it's not possible to cd inside the project and build it from
there (also opening that folder inside the IDE will trigger the creation of the files I added here).

This diff is fixing. The files have been generated with the command:

gw -p packages/react-native-gradle-plugin wrapper --gradle-version 7.0.2 --distribution-type=all

Changelog:
[Internal] [Added] - Setup Gradle Wrapper inside packages/react-native-gradle-plugin/

Differential Revision: D30730145

Summary:
This diff is setting up the Gradle wrapper inside packages/react-native-gradle-plugin/.
Currently the `./gradlew` file is missing so it's not possible to `cd` inside the project and build it from
there (also opening that folder inside the IDE will trigger the creation of the files I added here).

This diff is fixing. The files have been generated with the command:

```
gw -p packages/react-native-gradle-plugin wrapper --gradle-version 7.0.2 --distribution-type=all
```

Changelog:
[Internal] [Added] - Setup Gradle Wrapper inside packages/react-native-gradle-plugin/

Differential Revision: D30730145

fbshipit-source-id: 038060c7d7a8aaf96a14a72f637633be161ab2a0
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Sep 2, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D30730145

@pull-bot
Copy link
Copy Markdown

pull-bot commented Sep 2, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ad9d93e

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b1120c6

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,964,703 +0
android hermes armeabi-v7a 8,496,854 +0
android hermes x86 9,390,933 +0
android hermes x86_64 9,358,391 +0
android jsc arm64-v8a 10,628,158 +0
android jsc armeabi-v7a 9,549,495 +0
android jsc x86 10,641,388 +0
android jsc x86_64 11,252,563 +0

Base commit: b1120c6

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 040f548.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants