Skip to content

Fix "Running on device" in RNTester README#32169

Closed
osdnk wants to merge 1 commit into
facebook:mainfrom
osdnk:patch-1
Closed

Fix "Running on device" in RNTester README#32169
osdnk wants to merge 1 commit into
facebook:mainfrom
osdnk:patch-1

Conversation

@osdnk
Copy link
Copy Markdown
Contributor

@osdnk osdnk commented Sep 8, 2021

Summary

Fix broken link

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@osdnk osdnk requested a review from hramos as a code owner September 8, 2021 11:16
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2021
@pull-bot
Copy link
Copy Markdown

pull-bot commented Sep 8, 2021

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against c8b7e70

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a950634

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,957,348 +0
android hermes armeabi-v7a 8,490,627 +0
android hermes x86 9,377,567 +0
android hermes x86_64 9,342,887 +0
android jsc arm64-v8a 10,639,592 +0
android jsc armeabi-v7a 9,560,390 +0
android jsc x86 10,654,090 +0
android jsc x86_64 11,263,091 +0

Base commit: a950634

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@GijsWeterings has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@GijsWeterings merged this pull request in 21b2d6c.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants