Use Gradle Lazy API#32214
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Summary: This Diff updates part of the Gradle plugin to use the Gradle Lazy Api (mostly `Property` classes). This will defer the time when those value are accessed from configuration to execution phase. So far I've converted the `Extension` class that should be our primary entry point to the public API. I haven't converted the tasks as well, therefore we have several `.get()` calls around now. I'll take care of them once I go over the Tasks file as well. Moreover, I added some documentation to the Extention properties, as those will show up in the `build.gradle` autocompletion for our users. On the API point of view, this is going to be a breaking change for users that are testing the Gradle plugin AND are on Gradle Kotlin DSL (which I believe are really limited so I don't think is a problem at the moment). Users relying on `react.gradle` are unaffected. Changelog: [Internal] [Changed] - Use Gradle Lazy API Reviewed By: ShikaSD Differential Revision: D30902517 fbshipit-source-id: 20b5abc950fe397d7318fa3615e403f7fef17685
facebook-github-bot
added
p: Facebook
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D30902517 |
|
Base commit: c8873fc |
Base commit: c8873fc |
Contributor
|
This pull request has been merged in 578cba2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff updates part of the Gradle plugin to use the Gradle Lazy Api (mostly
Propertyclasses).This will defer the time when those value are accessed from configuration to execution phase.
So far I've converted the
Extensionclass that should be our primary entry point to the public API.I haven't converted the tasks as well, therefore we have several
.get()calls around now.I'll take care of them once I go over the Tasks file as well.
Moreover, I added some documentation to the Extention properties, as those will show up in the
build.gradleautocompletion for our users.
On the API point of view, this is going to be a breaking change for users that are testing the Gradle plugin AND
are on Gradle Kotlin DSL (which I believe are really limited so I don't think is a problem at the moment). Users
relying on
react.gradleare unaffected.Changelog:
[Internal] [Changed] - Use Gradle Lazy API
Reviewed By: ShikaSD
Differential Revision: D30902517