Skip to content

Upgrade to firebase^9.0.2 in ./bots#32218

Closed
yungsters wants to merge 5 commits into
facebook:mainfrom
yungsters:bots
Closed

Upgrade to firebase^9.0.2 in ./bots#32218
yungsters wants to merge 5 commits into
facebook:mainfrom
yungsters:bots

Conversation

@yungsters
Copy link
Copy Markdown
Contributor

Summary

Addresses the following couple security vulnerabilities.

Newer versions of the firebase dependency no longer depends on tar.

Changelog

[Internal]

Test Plan

See bots run on this pull request.

@yungsters yungsters requested a review from hramos as a code owner September 15, 2021 17:19
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 15, 2021
@yungsters
Copy link
Copy Markdown
Contributor Author

yungsters commented Sep 15, 2021

I expect to see failures because the Firebase API has breaking changes and I did not yet update call sites. I am publishing this pull request to verify that my Test Plan is sound.

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 15, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Copy Markdown
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yungsters yungsters added Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. and removed Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 15, 2021
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,705,285 +0
android hermes armeabi-v7a 7,236,467 +0
android hermes x86 8,126,260 +0
android hermes x86_64 8,091,221 +0
android jsc arm64-v8a 9,625,139 +0
android jsc armeabi-v7a 8,543,852 +0
android jsc x86 9,640,401 +0
android jsc x86_64 10,249,056 +0

Base commit: df331ae

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: df331ae

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@yungsters merged this pull request in 3024ec7.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 16, 2021
amgleitman added a commit to amgleitman/react-native-macos that referenced this pull request Mar 15, 2022
Summary:
Addresses the following couple security vulnerabilities.

- GHSA-9r2w-394v-53qc
- GHSA-qq89-hq3f-393p

Newer versions of the `firebase` dependency no longer depends on `tar`.

[Internal]

Pull Request resolved: facebook#32218

Test Plan: See bots run on this pull request.

Reviewed By: sammy-SC

Differential Revision: D30969643

Pulled By: yungsters

fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5
amgleitman added a commit to microsoft/react-native-macos that referenced this pull request Mar 15, 2022
amgleitman pushed a commit to amgleitman/react-native-macos that referenced this pull request Mar 16, 2022
Summary:
Addresses the following couple security vulnerabilities.

- GHSA-9r2w-394v-53qc
- GHSA-qq89-hq3f-393p

Newer versions of the `firebase` dependency no longer depends on `tar`.

## Changelog

[Internal]

Pull Request resolved: facebook#32218

Test Plan: See bots run on this pull request.

Reviewed By: sammy-SC

Differential Revision: D30969643

Pulled By: yungsters

fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5
amgleitman pushed a commit to amgleitman/react-native-macos that referenced this pull request Mar 16, 2022
Summary:
Addresses the following couple security vulnerabilities.

- GHSA-9r2w-394v-53qc
- GHSA-qq89-hq3f-393p

Newer versions of the `firebase` dependency no longer depends on `tar`.

## Changelog

[Internal]

Pull Request resolved: facebook#32218

Test Plan: See bots run on this pull request.

Reviewed By: sammy-SC

Differential Revision: D30969643

Pulled By: yungsters

fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5
HeyImChris pushed a commit to microsoft/react-native-macos that referenced this pull request Mar 17, 2022
Summary:
Addresses the following couple security vulnerabilities.

- GHSA-9r2w-394v-53qc
- GHSA-qq89-hq3f-393p

Newer versions of the `firebase` dependency no longer depends on `tar`.

## Changelog

[Internal]

Pull Request resolved: facebook#32218

Test Plan: See bots run on this pull request.

Reviewed By: sammy-SC

Differential Revision: D30969643

Pulled By: yungsters

fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5

Co-authored-by: Tim Yung <yungsters@fb.com>
HeyImChris pushed a commit to microsoft/react-native-macos that referenced this pull request Mar 17, 2022
Summary:
Addresses the following couple security vulnerabilities.

- GHSA-9r2w-394v-53qc
- GHSA-qq89-hq3f-393p

Newer versions of the `firebase` dependency no longer depends on `tar`.

## Changelog

[Internal]

Pull Request resolved: facebook#32218

Test Plan: See bots run on this pull request.

Reviewed By: sammy-SC

Differential Revision: D30969643

Pulled By: yungsters

fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5

Co-authored-by: Tim Yung <yungsters@fb.com>
@yungsters yungsters deleted the bots branch August 11, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants