Upgrade to firebase^9.0.2 in ./bots#32218
Closed
yungsters wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
I expect to see failures because the Firebase API has breaking changes and I did not yet update call sites. I am publishing this pull request to verify that my Test Plan is sound. |
Contributor
|
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Base commit: df331ae |
Base commit: df331ae |
Contributor
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@yungsters merged this pull request in 3024ec7. |
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Mar 15, 2022
Summary: Addresses the following couple security vulnerabilities. - GHSA-9r2w-394v-53qc - GHSA-qq89-hq3f-393p Newer versions of the `firebase` dependency no longer depends on `tar`. [Internal] Pull Request resolved: facebook#32218 Test Plan: See bots run on this pull request. Reviewed By: sammy-SC Differential Revision: D30969643 Pulled By: yungsters fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5
amgleitman
added a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 15, 2022
Upgrade to `firebase^9.0.2` in ./bots (facebook#32218)
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Mar 16, 2022
Summary: Addresses the following couple security vulnerabilities. - GHSA-9r2w-394v-53qc - GHSA-qq89-hq3f-393p Newer versions of the `firebase` dependency no longer depends on `tar`. ## Changelog [Internal] Pull Request resolved: facebook#32218 Test Plan: See bots run on this pull request. Reviewed By: sammy-SC Differential Revision: D30969643 Pulled By: yungsters fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5
amgleitman
pushed a commit
to amgleitman/react-native-macos
that referenced
this pull request
Mar 16, 2022
Summary: Addresses the following couple security vulnerabilities. - GHSA-9r2w-394v-53qc - GHSA-qq89-hq3f-393p Newer versions of the `firebase` dependency no longer depends on `tar`. ## Changelog [Internal] Pull Request resolved: facebook#32218 Test Plan: See bots run on this pull request. Reviewed By: sammy-SC Differential Revision: D30969643 Pulled By: yungsters fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5
HeyImChris
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 17, 2022
Summary: Addresses the following couple security vulnerabilities. - GHSA-9r2w-394v-53qc - GHSA-qq89-hq3f-393p Newer versions of the `firebase` dependency no longer depends on `tar`. ## Changelog [Internal] Pull Request resolved: facebook#32218 Test Plan: See bots run on this pull request. Reviewed By: sammy-SC Differential Revision: D30969643 Pulled By: yungsters fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5 Co-authored-by: Tim Yung <yungsters@fb.com>
HeyImChris
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 17, 2022
Summary: Addresses the following couple security vulnerabilities. - GHSA-9r2w-394v-53qc - GHSA-qq89-hq3f-393p Newer versions of the `firebase` dependency no longer depends on `tar`. ## Changelog [Internal] Pull Request resolved: facebook#32218 Test Plan: See bots run on this pull request. Reviewed By: sammy-SC Differential Revision: D30969643 Pulled By: yungsters fbshipit-source-id: 85c886ead7d8563dcaaef537f34bda57c7dc23a5 Co-authored-by: Tim Yung <yungsters@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the following couple security vulnerabilities.
Newer versions of the
firebasedependency no longer depends ontar.Changelog
[Internal]
Test Plan
See bots run on this pull request.