Skip to content

Fix applyAppPlugin being accessed too early in the React App Gradle Plugin#32420

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D31652984
Closed

Fix applyAppPlugin being accessed too early in the React App Gradle Plugin#32420
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D31652984

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
While working on the NDK AGP Apis, I realized the the applyAppPlugin is accessed
too early inside the Gradle plugin. Specifically is accessed once the plugin is applied,
and the extension is not configured afterwards. This means that the extension is always set
the default values.

I'm fixing it moving it inside the project.afterEvaluate that was already need to access
the variant informations.

Changelog:
[Internal] [Changed] - Fix applyAppPlugin being accessed too early in the React App Gradle Plugin

Reviewed By: ShikaSD

Differential Revision: D31652984

…lugin

Summary:
While working on the NDK AGP Apis, I realized the the `applyAppPlugin` is accessed
too early inside the Gradle plugin. Specifically is accessed once the plugin is applied,
and the extension is not configured afterwards. This means that the extension is always set
the default values.

I'm fixing it moving it inside the `project.afterEvaluate` that was already need to access
the variant informations.

Changelog:
[Internal] [Changed] - Fix applyAppPlugin being accessed too early in the React App Gradle Plugin

Reviewed By: ShikaSD

Differential Revision: D31652984

fbshipit-source-id: 348b64f27e15a7de5daa97163f0da8a80a2fd920
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 18, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D31652984

@pull-bot
Copy link
Copy Markdown

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 7a79062

@pull-bot
Copy link
Copy Markdown

PR build artifact for 7a79062 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dfe42d6

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,981,012 +1,263,754
android hermes armeabi-v7a 8,507,581 +1,263,759
android hermes x86 9,399,869 +1,263,751
android hermes x86_64 9,365,534 +1,263,764
android jsc arm64-v8a 10,652,513 +1,016,275
android jsc armeabi-v7a 9,566,598 +1,016,277
android jsc x86 10,665,650 +1,016,279
android jsc x86_64 11,275,013 +1,016,299

Base commit: dfe42d6

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 79e72e0.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants