Fix applyAppPlugin being accessed too early in the React App Gradle Plugin#32420
Closed
cortinico wants to merge 1 commit into
Closed
Fix applyAppPlugin being accessed too early in the React App Gradle Plugin#32420cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
…lugin Summary: While working on the NDK AGP Apis, I realized the the `applyAppPlugin` is accessed too early inside the Gradle plugin. Specifically is accessed once the plugin is applied, and the extension is not configured afterwards. This means that the extension is always set the default values. I'm fixing it moving it inside the `project.afterEvaluate` that was already need to access the variant informations. Changelog: [Internal] [Changed] - Fix applyAppPlugin being accessed too early in the React App Gradle Plugin Reviewed By: ShikaSD Differential Revision: D31652984 fbshipit-source-id: 348b64f27e15a7de5daa97163f0da8a80a2fd920
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31652984 |
|
|
PR build artifact for 7a79062 is ready. |
Base commit: dfe42d6 |
Base commit: dfe42d6 |
Contributor
|
This pull request has been merged in 79e72e0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working on the NDK AGP Apis, I realized the the
applyAppPluginis accessedtoo early inside the Gradle plugin. Specifically is accessed once the plugin is applied,
and the extension is not configured afterwards. This means that the extension is always set
the default values.
I'm fixing it moving it inside the
project.afterEvaluatethat was already need to accessthe variant informations.
Changelog:
[Internal] [Changed] - Fix applyAppPlugin being accessed too early in the React App Gradle Plugin
Reviewed By: ShikaSD
Differential Revision: D31652984