Skip to content

Enable complete_nullability on //xplat/js/react-native-github:RCTTypeSafety#32473

Closed
MosheBerman wants to merge 1 commit into
facebook:mainfrom
MosheBerman:export-D31775069
Closed

Enable complete_nullability on //xplat/js/react-native-github:RCTTypeSafety#32473
MosheBerman wants to merge 1 commit into
facebook:mainfrom
MosheBerman:export-D31775069

Conversation

@MosheBerman
Copy link
Copy Markdown

Reviewed By: AdamCmiel

Differential Revision: D31775069

…Safety

Reviewed By: AdamCmiel

Differential Revision: D31775069

fbshipit-source-id: 6fc1ea7d45c022221a582187aab2b8908d45b778
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 25, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D31775069

@pull-bot
Copy link
Copy Markdown

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a4e965a

@pull-bot
Copy link
Copy Markdown

PR build artifact for a4e965a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,289,089 +0
android hermes armeabi-v7a 7,853,228 +0
android hermes x86 8,656,149 +0
android hermes x86_64 8,615,287 +0
android jsc arm64-v8a 9,791,039 +0
android jsc armeabi-v7a 8,751,976 +0
android jsc x86 9,739,953 +0
android jsc x86_64 10,340,809 +0

Base commit: 65af5eb
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 65af5eb
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 27, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in fdd744f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants