Add workflow to create version labels on new releases#32508
Add workflow to create version labels on new releases#32508lucasbento wants to merge 4 commits intofacebook:mainfrom
Conversation
|
|
PR build artifact for 4f25959 is ready. |
Was this approach discussed somewhere? Is there a reason why we're not using Milestone instead? |
Base commit: 6790cf1 |
It was discussed on Discord, not sure about the milestones, perhaps @lunaleaps can chime in. |
|
PR build artifact for f9d167e is ready. |
|
Hey @cortinico, yea as @lucasbento mentioned we've been talking about deprecating upgrade-support repo to have upgrade issues reported in this repo. We want to get signal of how many issues come up when people attempt to migrate to a specific version so we can feedback on how stable our releases are -- hence using labels. From looking at milestones, I think the use case seems to be more about tracking a specific goal -- or am I misunderstanding? |
| label: Developer Environment | ||
| description: Please list relevant versions of system, tooling. Ex. OS, processor, Xcode, etc. | ||
| label: Output of `react-native info` | ||
| description: Run `react-native info` in your terminal, copy and paste the results here. |
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Sorry I didn't wanted to sidetrack your original work. If you already spent time discussing on this, feel free to merge it as it is. I anyway think that using milestones for this kind of work would be better for a variety of reasons:
That's true, if used on PRs. Milestone are basically "version" information that can be attached to an issue or a PR. Say for a potential milestone "0.67.0", I would use it in a following way:
The problem that I see with the current approach are the following:
|
|
@cortinico Thanks for sharing your thoughts! For sure good points and good things to address. At this stage I think labels work well because internal tooling already scrapes this information and I'm not sure if milestones are. I think this is something we can ask about but I already have some tables built out for getting this information. Is there a cause for concern if there are too many labels? Not exactly sure the cost except for maybe some upper bound of labels that Github allows? Tried searching around but can't find. Re: react-native-bot, would that not be an actor that would still need to perform these actions? We can look into conforming the tools -- first want to focus on use-case |
cortinico
left a comment
There was a problem hiding this comment.
Is there a cause for concern if there are too many labels? Not exactly sure the cost except for maybe some upper bound of labels that Github allows? Tried searching around but can't find.
I don't think we're going to hit the limit (if any) :) Is more like a practicality 👍
but I already have some tables built out for getting this information.
Yup I didn't want to slow down 👍 Feel free to merge it
|
@lunaleaps merged this pull request in 60352a9. |
Summary
This PR adds the following GitHub actions:
Version: 0.65.1) whenever there's a new release;Changelog
N/A.
Few things to keep in mind
Example of issue with version label: lucasbento/test-issue-forms#4