Skip to content

chore: make CLI error message more descriptive pt2#32598

Closed
vonovak wants to merge 2 commits into
facebook:mainfrom
vonovak:patch-19
Closed

chore: make CLI error message more descriptive pt2#32598
vonovak wants to merge 2 commits into
facebook:mainfrom
vonovak:patch-19

Conversation

@vonovak
Copy link
Copy Markdown
Contributor

@vonovak vonovak commented Nov 15, 2021

follow up to #32593

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 15, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Copy Markdown
Contributor

follow up to #32593

Thanks for this. The other PR was accidentally merged by mistake.

@vonovak
Copy link
Copy Markdown
Contributor Author

vonovak commented Nov 15, 2021

thanks, yeah, I thought I would add to the previous one but 🤷‍♂️ 🙂

@pull-bot
Copy link
Copy Markdown

pull-bot commented Nov 15, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against df96c87

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 15, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 79cf25b
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 15, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,477,943 +0
android hermes armeabi-v7a 7,775,189 +0
android hermes x86 8,947,093 +0
android hermes x86_64 8,894,003 +0
android jsc arm64-v8a 9,791,890 +0
android jsc armeabi-v7a 8,752,625 +0
android jsc x86 9,740,716 +0
android jsc x86_64 10,341,569 +0

Base commit: 79cf25b
Branch: main

…ok/react/utils/PathUtils.kt

Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 17, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in aabf7f7.

@vonovak vonovak deleted the patch-19 branch November 17, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants