Fix Dead links to documents in the comments#32619
Closed
Naturalclar wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 26e30a5 |
Base commit: 26e30a5 |
Contributor
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
cortinico
requested changes
Nov 19, 2021
| * See https://reactnative.dev/docs/vibration#vibrate | ||
| */ | ||
| vibrate: function ( | ||
| vibrate: function( |
Contributor
There was a problem hiding this comment.
This change should be amended as it's making the CI fail
| * See https://reactnative.dev/docs/vibration#cancel | ||
| */ | ||
| cancel: function () { | ||
| cancel: function() { |
Contributor
Author
There was a problem hiding this comment.
@cortinico thanks for the review! fixed the format
Contributor
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 00bb2ba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Links under
reactnative.devthat ended with.htmllead to Page not found.Fixed the url so that users get sent to the appropriate url.
Changelog
[General] [Fixed] - Fixed dead links in the comments.
Test Plan