Make Danger Phabricator-friendly.#32642
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Summary: This Diff adapts the Dangerfile to be a bit more friendly for PRs that are exported from Phabricator. Specifically, I'm disabling the check for Test Plan as those are not exported externally. The check for Summary and Changelog are instead adapted to work with the format exported for Phabricator. Changelog: [Internal] [Changed] - Make Danger Phabricator-friendly Differential Revision: D32594622 fbshipit-source-id: 08727587357bdfd01ed7ef6428db634004d19ab5
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32594622 |
Base commit: 19bca22 |
Base commit: 19bca22 |
Contributor
|
This pull request has been merged in 5273553. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff adapts the Dangerfile to be a bit more friendly
for PRs that are exported from Phabricator. Specifically,
I'm disabling the check for Test Plan as those are not exported
externally. The check for Summary and Changelog are instead adapted
to work with the format exported for Phabricator.
Changelog:
[Internal] [Changed] - Make Danger Phabricator-friendly
Differential Revision: D32594622