Build codegen package in pod install#32678
Closed
sota000 wants to merge 1 commit into
Closed
Conversation
Summary: In D32420306 (facebook@3d8b5a3) (facebook@3d8b5a3), I added a phase which uses a codegen, but it assumed that the codegen package has already been built. This diff fixes the issue where it checks and build the codegen packaage. I also reverted the change that I made for the circle CI test since it now builds the codegen when running pod install. Differential Revision: D32707588 fbshipit-source-id: 2ae92efea73a948afa6d99292432e44531e52b4d
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32707588 |
|
Base commit: 3352b57 |
Base commit: 3352b57 |
ken0nek
reviewed
Nov 30, 2021
| elsif Dir.exist?(codegen_npm_path) | ||
| codegen_cli_path = codegen_npm_path | ||
| else | ||
| raise "[codegen] Couldn't not find react-native-codegen." |
Contributor
There was a problem hiding this comment.
Typo: Should it be Couldn't or Could not?
Contributor
|
This pull request has been merged in 363ff5c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In D32420306 (3d8b5a3) (3d8b5a3), I added a phase which uses a codegen, but it assumed that the codegen package has already been built. This diff fixes the issue where it checks and build the codegen packaage.
I also reverted the change that I made for the circle CI test since it now builds the codegen when running pod install.
Differential Revision: D32707588