Add a dependency to the native component example added to RNTester#32693
Closed
sota000 wants to merge 2 commits into
Closed
Add a dependency to the native component example added to RNTester#32693sota000 wants to merge 2 commits into
sota000 wants to merge 2 commits into
Conversation
Summary: Changelog: [Internal] Adding an option in RN Tester to enable the new codegen discovery option where it uses generate-artifacts.js to codegen native files. It also updates generate-artifacts.js to support the case where react-native is not within node_modules. Differential Revision: D32777912 fbshipit-source-id: 334382e2a2ef76be23e26c85e6bf3a86680400a2
Summary: Changelog: [Internal] this diff adds dependecies to the buck files so that an internal app that referes RNtester will work as intended. Differential Revision: D32778338 fbshipit-source-id: 3d248efa1a79b5960f48c69ebc88ad6521aa9db4
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32778338 |
Base commit: 2bb91ae |
Base commit: 2bb91ae |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32778338 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32778338 |
sota000
added a commit
to sota000/react-native
that referenced
this pull request
Dec 3, 2021
…acebook#32693) Summary: Pull Request resolved: facebook#32693 Changelog: [Internal] this diff adds dependecies to the buck files so that an internal app that referes RNtester will work as intended. Reviewed By: cortinico Differential Revision: D32778338 fbshipit-source-id: 8d728e1823c0330c1318cd6ca8d0b74b0ed2a238
Collaborator
|
This pull request was successfully merged by @sota000 in 173d3a4. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been reverted by 8e49658. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal] this diff adds dependecies to the buck files so that an internal app that referes RNtester will work as intended.
Differential Revision: D32778338