Don't validate ENTRY_FILE in react-native-xcode.sh

[janicduplessis]

Summary

Reverts #29012

It is not really possible to properly validate if ENTRY_FILE exists since it is resolved by metro, and the server is not always running from the app root, like in a monorepo with multiple RN apps running on the same metro server.

In my case I run metro on the repo root and entry file will be something like apps/app/index.js. -f "$ENTRY_FILE" will fail since the script is run from the project folder (PROJECT_ROOT, in my case the apps/app folder, so it tries to resolve apps/app/apps/app/index.js).

I don't think this check is actually useful since metro will report the error if the entry file is invalid (fixed in #30150). The error is not as user friendly, but I think it is still fine. Maybe it could be improved in metro.

Changelog

[iOS] [Fixed] - Don't validate ENTRY_FILE in react-native-xcode.sh

Test Plan

Before

After if file is actually missing

After if file exists, builds successfully.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: a0e6ffe
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,782,640	+0
android	hermes	armeabi-v7a	7,172,350	+0
android	hermes	x86	8,093,283	+0
android	hermes	x86_64	8,069,317	+0
android	jsc	arm64-v8a	9,649,489	+0
android	jsc	armeabi-v7a	8,408,181	+0
android	jsc	x86	9,600,998	+0
android	jsc	x86_64	10,194,061	+0

Base commit: a0e6ffe
Branch: main

[GastonRosso]

Hi @janicduplessis thanks for this, we were having the same issue here. Will it be possible to merge this?

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @janicduplessis in 780fe80.

^{When will my fix make it into a release? | Upcoming Releases}