Fix an iOS codegen use case when SRCS_PATTERN is not provided.#32925
Closed
sota000 wants to merge 1 commit into
Closed
Fix an iOS codegen use case when SRCS_PATTERN is not provided.#32925sota000 wants to merge 1 commit into
sota000 wants to merge 1 commit into
Conversation
Summary: Changelog: [internal] I was testing with some sample proect without the codegen discovery, and I found a code path that doesn't work due to the escape charactors left. Differential Revision: D33670881 fbshipit-source-id: 7d1075cec81f9dd1f99f2555ab19b98ad05028e9
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33670881 |
Base commit: 5fa3807 |
Base commit: 5fa3807 |
Collaborator
|
This pull request was successfully merged by @sota000 in 30e1f9c. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [internal] I was testing with some sample proect without the codegen discovery, and I found a code path that doesn't work due to the escape charactors left.
Differential Revision: D33670881