Skip to content

fix: Screen reader event name on RNTester AccessibilityExample#32926

Closed
gabrieldonadel wants to merge 1 commit into
facebook:mainfrom
gabrieldonadel:fix-accessibility-example-screen-reader
Closed

fix: Screen reader event name on RNTester AccessibilityExample#32926
gabrieldonadel wants to merge 1 commit into
facebook:mainfrom
gabrieldonadel:fix-accessibility-example-screen-reader

Conversation

@gabrieldonadel
Copy link
Copy Markdown
Collaborator

Summary

Fix an issue in the AccessibilityExample on RNTester where the Screen Reader item would listen for the reduceMotionChanged event instead of the screenReaderChanged event

Changelog

[General] [Fixed] - Fix screen reader event name on RNTester AccessibilityExample

Test Plan

  1. Build iOS app
  2. Navigate to the Accessibility page
  3. Switch over to settings and change VoiceOver at Settings>Accessibility>VoiceOver>VoiceOver
  4. Switch back to the app and see the results
voice-over.mp4

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2022
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 20, 2022
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5fa3807
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,290,858 +0
android hermes armeabi-v7a 7,628,205 -6
android hermes x86 8,764,064 +6
android hermes x86_64 8,700,923 -3
android jsc arm64-v8a 9,678,238 +3
android jsc armeabi-v7a 8,672,272 +6
android jsc x86 9,636,943 +7
android jsc x86_64 10,231,411 +5

Base commit: 5fa3807
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gabrieldonadel in b276b73.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 20, 2022
@gabrieldonadel gabrieldonadel deleted the fix-accessibility-example-screen-reader branch January 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants