Fix config file dir incorrectly set in the build time codegen.#32946
Closed
sota000 wants to merge 1 commit into
Closed
Fix config file dir incorrectly set in the build time codegen.#32946sota000 wants to merge 1 commit into
sota000 wants to merge 1 commit into
Conversation
Summary: Changelog: [Internal] This fixes a bug where config file dir was incorrectly and breaks the codegen which runs when building an app. Differential Revision: D33724558 fbshipit-source-id: a667c49b3e3802bc4b192b09d0b20415ef5647cd
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33724558 |
Base commit: 48f6967 |
Base commit: 48f6967 |
cortinico
reviewed
Jan 24, 2022
| @@ -1,9 +1,9 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
| # Copyright (c) Facebook, Inc. and its affiliates. | |||
Contributor
There was a problem hiding this comment.
I think we want to amend this :)
Collaborator
|
This pull request was successfully merged by @sota000 in c48e5ac. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This fixes a bug where config file dir was incorrectly and breaks the codegen which runs when building an app.
Differential Revision: D33724558