onDismiss to be an RCTDirectEventBlock

[HeyImChris]

Summary

We're seeing a red box that Component 'RCTModalHostView' re-registered bubbling event 'topDismiss' as a direct event moduleConstantsForComponent in some downstream react-native-macOS builds.

Looking at other usage of this object, we treat it as a direct event block everywhere else, just this one spot it's a bubbling event block. It was added with this PR which doesn't explicitly address the desire for the prop to bubble up through the view hierarchy or not, so I'm guessing it was just mislabeled and should be direct like the other usages.

Changelog

[iOS] [Bug] - Fix modal redbox for onDismiss

Test Plan

We don't redbox downstream anymore

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 24674c5

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 97f3eb2
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,204,201	-1,381
android	hermes	armeabi-v7a	7,811,068	-3,214
android	hermes	x86	8,575,744	-1,571
android	hermes	x86_64	8,526,542	-1,176
android	jsc	arm64-v8a	9,872,944	-1,443
android	jsc	armeabi-v7a	8,864,360	-3,263
android	jsc	x86	9,840,570	-1,636
android	jsc	x86_64	10,435,497	-1,244

Base commit: 97f3eb2
Branch: main

[facebook-github-bot]

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @HeyImChris in 46f68ac.

^{When will my fix make it into a release? | Upcoming Releases}