Added Gemfile.lock to git add files when calling update-ruby.sh#33484
Closed
danilobuerger wants to merge 1 commit into
Closed
Added Gemfile.lock to git add files when calling update-ruby.sh#33484danilobuerger wants to merge 1 commit into
danilobuerger wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 0a517ae |
Base commit: 0a517ae |
Contributor
Author
|
Tests failing are unrelated, they happen on main too. |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Mar 24, 2022
Collaborator
|
This pull request was successfully merged by @danilobuerger in 96c611b. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…book#33484) Summary: In https://github.com/facebook/react-native/blob/main/scripts/update-ruby.sh#L61 ```bash bundle lock ``` is called which creates a Gemfile.lock in the rn root. This file should be in the git add files list along with the other files that get updated by that script. ## Changelog [Internal] [Fixed] - Added Gemfile.lock to git add files when calling update-ruby.sh Pull Request resolved: facebook#33484 Test Plan: Call update-ruby.sh with or without this patch. Without this patch, the Gemfile.lock will not be staged, with this patch, the Gemfile.lock will be staged. Reviewed By: GijsWeterings Differential Revision: D35118250 Pulled By: cortinico fbshipit-source-id: 80f2c7fad6fbc3f09697988dcc20f7ac94a21473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In https://github.com/facebook/react-native/blob/main/scripts/update-ruby.sh#L61
is called which creates a Gemfile.lock in the rn root. This file should be in the git add files list along with the other files that get updated by that script.
Changelog
[Internal] [Fixed] - Added Gemfile.lock to git add files when calling update-ruby.sh
Test Plan
Call update-ruby.sh with or without this patch. Without this patch, the Gemfile.lock will not be staged, with this patch, the Gemfile.lock will be staged.