(AppState) fix removeEventListener adding another listener when type is blur or focus#33491
Closed
AntoineDoubovetzky wants to merge 1 commit into
Closed
Conversation
…e is blur or focus
facebook-github-bot
added
CLA Signed
Base commit: 19cf702 |
Base commit: 19cf702 |
Contributor
|
@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @AntoineDoubovetzky in 9aab25e. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…is blur or focus (facebook#33491) Summary: I noticed the `AppState.removeEventListener` was in fact calling `addListener` instead of `removeListener` when type is blur or focus. I know this method is deprecated but it can't hurt to fix it. ## Changelog [General] [Fixed] - AppState.removeEventListener correctly removes listener for blur and focus events Pull Request resolved: facebook#33491 Test Plan: I've thought about adding a unit test, but it isn't that easy since AppState is mocked and the method is deprecated so I don't think it is worth investing too much for it. Reviewed By: cortinico Differential Revision: D35139808 Pulled By: GijsWeterings fbshipit-source-id: 9d8ba157db3a62ea53759e1246f483182faf12f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed the
AppState.removeEventListenerwas in fact callingaddListenerinstead ofremoveListenerwhen type is blur or focus.I know this method is deprecated but it can't hurt to fix it.
Changelog
[General] [Fixed] - AppState.removeEventListener correctly removes listener for blur and focus events
Test Plan
I've thought about adding a unit test, but it isn't that easy since AppState is mocked and the method is deprecated so I don't think it is worth investing too much for it.