chore: add headers.Content-type to openFileInEditor call

[andrejborstnik]

Summary

Currently the Content-type is not defined and defaults to text/plain. This makes it more accurate.

Changelog

[internal] [Changed] - add headers.Content-type to openFileInEditor call

Test Plan

• in development trigger openFileInEditor, e.g. by pressing on a line in a stack trace -> code editor opens

[facebook-github-bot]

Hi @andrejborstnik!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: d2e8e7d
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[andrejborstnik]

This is still pending review and is not stale

[cortinico]

@andrejborstnik THanks for sending over this PR.

Currently the Content-type is not defined and defaults to text/plain. This makes it more accurate.

Is this necessary for any specific reason?

[andrejborstnik]

@andrejborstnik THanks for sending over this PR.

Currently the Content-type is not defined and defaults to text/plain. This makes it more accurate.

Is this necessary for any specific reason?

@cortinico the body sent actually is a JSON, not text, so this is a more accurate description of what the request does.

For our specific use-case we only allow application/json payloads in some cases for security hardening reasons, for example when openFileInEditor calls react-native-community/cli it (our fork) checks the payload type.

Happy to provide any further info

[cortinico]

Thanks for the clarification 👍

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @andrejborstnik in 43cf78d.

^{When will my fix make it into a release? | Upcoming Releases}