fix //xplat/js/react-native-github:codegen_rn_components_schema_rncore#33518
Closed
weih9 wants to merge 1 commit into
Closed
fix //xplat/js/react-native-github:codegen_rn_components_schema_rncore#33518weih9 wants to merge 1 commit into
weih9 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35188154 |
Base commit: 28064ee |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35188154 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35188154 |
facebook#33518) Summary: Pull Request resolved: facebook#33518 Changelog: [Internal] When building with buck2, `setup_env_vars.sh` cannot be found. exporting setup_env_vars.sh and adding it as a dep to `write_to_json` fixes it. Reviewed By: d16r Differential Revision: D35188154 fbshipit-source-id: 5baa012ed13e0e90a809bda1cfdef6a6ae5fbf74
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35188154 |
Base commit: 28064ee |
Collaborator
|
This pull request was successfully merged by @weih9 in 0353852. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
facebook#33518) Summary: Pull Request resolved: facebook#33518 Changelog: [Internal] When building with buck2, `setup_env_vars.sh` cannot be found. exporting setup_env_vars.sh and adding it as a dep to `write_to_json` fixes it. Reviewed By: d16r Differential Revision: D35188154 fbshipit-source-id: e1e1be4c83a57e443a181efaf1af3e6c8e6452f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
When building with buck2,
setup_env_vars.shcannot be found. exporting setup_env_vars.sh and adding it as a dep towrite_to_jsonfixes it.Reviewed By: d16r
Differential Revision: D35188154