Skip to content

Add exported Kotlin stdlib for Kotlin module to enable OSS build#33535

Closed
ShikaSD wants to merge 1 commit into
facebook:mainfrom
ShikaSD:export-D35284430
Closed

Add exported Kotlin stdlib for Kotlin module to enable OSS build#33535
ShikaSD wants to merge 1 commit into
facebook:mainfrom
ShikaSD:export-D35284430

Conversation

@ShikaSD
Copy link
Copy Markdown
Contributor

@ShikaSD ShikaSD commented Mar 31, 2022

Summary:
Adds Kotlin stdlib as exported dependency to make sure upstream targets include Kotlin jvm internal classes.

Changelog: [Internal]

Differential Revision: D35284430

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 31, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 31, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 8adedfe
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@facebook-github-bot
Add kotlin stdlib as a dependency for Java targets depending on Kotlin (
aad407a 
facebook#33535)

Summary:
Pull Request resolved: facebook#33535

Hack to support Kotlin functions in Buck compilation: adds Kotlin stdlib as a dependency to make sure upstream targets include Kotlin jvm internal classes.

Changelog: [Internal]

Differential Revision: D35284430

fbshipit-source-id: 239007fd297d01c8917d53baa696e0114987aec4
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35284430

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Mar 31, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,809,731 -180,259
android hermes armeabi-v7a 7,201,410 -163,431
android hermes x86 8,118,473 -208,265
android hermes x86_64 8,098,650 -196,959
android jsc arm64-v8a 9,643,576 +7,270
android jsc armeabi-v7a 8,417,829 +6,881
android jsc x86 9,592,769 +7,360
android jsc x86_64 10,189,948 +7,538

Base commit: 8adedfe
Branch: main

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Apr 1, 2022

This pull request was successfully merged by @ShikaSD in 651c4c1.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 1, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@Saadnajmi
Add kotlin stdlib as a dependency for Java targets depending on Kotlin (
af1ba94 
facebook#33535)

Summary:
Pull Request resolved: facebook#33535

Hack to support Kotlin functions in Buck compilation: adds Kotlin stdlib as a dependency to make sure upstream targets include Kotlin jvm internal classes.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D35284430

fbshipit-source-id: 0d29ad30386514c8df5376d0a6809d3105f0cd0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShikaSD @facebook-github-bot @analysis-bot @react-native-bot