Use arbitrary hermes-engine.podspec during build#33549
Closed
hramos wants to merge 5 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35300595 |
Differential Revision: D35299690 fbshipit-source-id: a8528b7b431a23fa17b40c3709aeb4e3ab9f3746
Differential Revision: D35294993 fbshipit-source-id: 262706ae728bc056dcc41af94a76a1e7094b0153
Differential Revision: D35295708 fbshipit-source-id: 8e11b82f472bff7b0b46bfc051b35c6808416a92
Differential Revision: D35297994 fbshipit-source-id: ea05ed2f53ab0738067b6f4902f477f038ec276d
Summary: Pull Request resolved: facebook#33549 When building Hermes from source, use arbitrary hermes-engine.podspec to ensure correct Hermes tag is used by CocoaPods. Without this change, CocoaPods will check out the `v0.11.0` git tag from the `facebook/hermes` git repository. Ideally, this change should be done in the original `hermes-engine.podspec` in `facebook/hermes`. For now, use the arbitrary copy until the canonical Pod has been updated. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D35300595 fbshipit-source-id: 1c89f2a4f3734d46d0a759d21e6f4872728662b8
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35300595 |
Collaborator
|
This pull request was successfully merged by @hramos in ada6c71. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33549 When building Hermes from source, use arbitrary hermes-engine.podspec to ensure correct Hermes tag is used by CocoaPods. Without this change, CocoaPods will check out the `v0.11.0` git tag from the `facebook/hermes` git repository. Ideally, this change should be done in the original `hermes-engine.podspec` in `facebook/hermes`. For now, use the arbitrary copy until the canonical Pod has been updated. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D35300595 fbshipit-source-id: be4b1225eb2c2a88958cd9e5e98cb8efed343bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When building Hermes from source, use arbitrary hermes-engine.podspec to ensure correct Hermes tag is used by CocoaPods.
Without this change, CocoaPods will check out the
v0.11.0git tag from thefacebook/hermesgit repository.Ideally, this change should be done in the original
hermes-engine.podspecinfacebook/hermes. For now, use the arbitrary copy until the canonical Pod has been updated.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D35300595