Enable ICF and LTO (#720)#33560
Closed
neildhar wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35344254 |
|
Base commit: 472d531 |
Differential Revision: D35342731 fbshipit-source-id: 62abf45668e6363b8beeda04b18e710653e51ad6
Differential Revision: D35347444 fbshipit-source-id: 0143557a5b938ce21717c03e55e93174bd206afe
Summary: Turn on ICF for the build whenever it is available. This requires us to link with LLD, which is only the default starting in NDK r23, so manually specify LLD for the Android build. Also turn on LTO for the CircleCI build, so we generate highly optimised binaries for distribution. X-link: facebook/hermes#720 Differential Revision: D35344254 fbshipit-source-id: 0030d17c1ce326ef603b952d3b44330782e51d55
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35344254 |
neildhar
force-pushed
the
export-D35344254
branch
from
0c97aaa to
aaf8274
Compare
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Apr 5, 2022
Summary: X-link: facebook/react-native#33560 Pull Request resolved: #720 Turn on ICF for the build whenever it is available. This requires us to link with LLD, which is only the default starting in NDK r23, so manually specify LLD for the Android build. Also turn on LTO for the CircleCI build, so we generate highly optimised binaries for distribution. Changelog: [Internal] Reviewed By: jpporto Differential Revision: D35344254 fbshipit-source-id: 64b37e6a7817a7b7826cc7480468367b95d63c61
Collaborator
|
This pull request was successfully merged by @neildhar in 6f26a92. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33560 X-link: facebook/hermes#720 Turn on ICF for the build whenever it is available. This requires us to link with LLD, which is only the default starting in NDK r23, so manually specify LLD for the Android build. Also turn on LTO for the CircleCI build, so we generate highly optimised binaries for distribution. Changelog: [Internal] Reviewed By: jpporto Differential Revision: D35344254 fbshipit-source-id: 64b37e6a7817a7b7826cc7480468367b95d63c61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: facebook/hermes#720
Differential Revision: D35344254