Skip to content

Circle CI: enable BUILD_HERMES_SOURCE for test_ios_rntester job #33585

Closed
matinzd wants to merge 5 commits into
facebook:mainfrom
matinzd:ci/fix_ios_rn_tester
Closed

Circle CI: enable BUILD_HERMES_SOURCE for test_ios_rntester job #33585
matinzd wants to merge 5 commits into
facebook:mainfrom
matinzd:ci/fix_ios_rn_tester

Conversation

@matinzd
Copy link
Copy Markdown
Contributor

@matinzd matinzd commented Apr 7, 2022

Summary

Fix CircleCI build for test_ios_rntester.

Broken due to this commit after adding dev tools profiler.

Changelog

[Internal] [Fixed] - Fix rn tester app CI

Test Plan

CI should be green.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2022
@matinzd matinzd changed the title fix: rn tester ios fix(ci): enable BUILD_HERMES_SOURCE on rn tester ios Apr 7, 2022
@matinzd matinzd marked this pull request as ready for review April 7, 2022 09:32
@matinzd matinzd requested a review from hramos as a code owner April 7, 2022 09:32
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 7, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9573d7b
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 7, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,766,132 +56
android hermes armeabi-v7a 7,169,928 +20
android hermes x86 8,072,343 +2
android hermes x86_64 8,052,418 -33
android jsc arm64-v8a 9,643,369 +58
android jsc armeabi-v7a 8,417,600 +20
android jsc x86 9,592,551 +5
android jsc x86_64 10,189,746 -14

Base commit: 9573d7b
Branch: main

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 7, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico
Copy link
Copy Markdown
Contributor

Thanks for doing this @matinzd 👍 Let me take a closer look but we should be good merging this if the CI is green

@matinzd matinzd marked this pull request as draft April 7, 2022 10:26
@matinzd
Copy link
Copy Markdown
Contributor Author

matinzd commented Apr 7, 2022

Thanks for doing this @matinzd 👍 Let me take a closer look but we should be good merging this if the CI is green

I converted it to a draft since there are some problems that need to be fixed. I will let you know when it's ready.

@matinzd matinzd marked this pull request as ready for review April 7, 2022 10:49
@matinzd matinzd changed the title fix(ci): enable BUILD_HERMES_SOURCE on rn tester ios Circle CI: enable BUILD_HERMES_SOURCE for test_ios_rntester job Apr 7, 2022
Comment thread .circleci/config.yml
Comment thread scripts/react_native_pods.rb Outdated
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @matinzd in 8de1c9c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 7, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
…book#33585)

Summary:
Fix CircleCI build for test_ios_rntester.

Broken due to [this commit](facebook@fefa7b6) after adding dev tools profiler.

## Changelog

[Internal] [Fixed] - Fix rn tester app CI

Pull Request resolved: facebook#33585

Test Plan: CI should be green.

Reviewed By: neildhar

Differential Revision: D35462642

Pulled By: cortinico

fbshipit-source-id: dbcb0a7e2e58fac1c77b2dbe4b833812175dc87c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants