Circle CI: enable BUILD_HERMES_SOURCE for test_ios_rntester job #33585
Closed
matinzd wants to merge 5 commits into
Closed
Circle CI: enable BUILD_HERMES_SOURCE for test_ios_rntester job #33585matinzd wants to merge 5 commits into
matinzd wants to merge 5 commits into
Conversation
Base commit: 9573d7b |
Base commit: 9573d7b |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Thanks for doing this @matinzd 👍 Let me take a closer look but we should be good merging this if the CI is green |
Contributor
Author
I converted it to a draft since there are some problems that need to be fixed. I will let you know when it's ready. |
cortinico
reviewed
Apr 7, 2022
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @matinzd in 8de1c9c. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…book#33585) Summary: Fix CircleCI build for test_ios_rntester. Broken due to [this commit](facebook@fefa7b6) after adding dev tools profiler. ## Changelog [Internal] [Fixed] - Fix rn tester app CI Pull Request resolved: facebook#33585 Test Plan: CI should be green. Reviewed By: neildhar Differential Revision: D35462642 Pulled By: cortinico fbshipit-source-id: dbcb0a7e2e58fac1c77b2dbe4b833812175dc87c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CircleCI build for test_ios_rntester.
Broken due to this commit after adding dev tools profiler.
Changelog
[Internal] [Fixed] - Fix rn tester app CI
Test Plan
CI should be green.