Update CodeGen to leverage the outputDir as suggested in diff review#33729
Closed
cipolleschi wants to merge 4 commits into
Closed
Update CodeGen to leverage the outputDir as suggested in diff review#33729cipolleschi wants to merge 4 commits into
outputDir as suggested in diff review#33729cipolleschi wants to merge 4 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
cipolleschi
force-pushed
the
export-D35935282
branch
from
bc426f3 to
14daf33
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
cipolleschi
force-pushed
the
export-D35935282
branch
from
14daf33 to
c732728
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
cipolleschi
force-pushed
the
export-D35935282
branch
from
c732728 to
635124f
Compare
Base commit: d992ae0 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
cipolleschi
force-pushed
the
export-D35935282
branch
from
635124f to
d0e3865
Compare
cipolleschi
force-pushed
the
export-D35935282
branch
from
d0e3865 to
cbc8ad2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
cipolleschi
force-pushed
the
export-D35935282
branch
from
cbc8ad2 to
978a714
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
Base commit: d992ae0 |
added 2 commits
May 1, 2022 07:54
Summary: This Diff introduces some changes in the CodeGen to properly generate the types in the right folder. ## Issue The codegen on iOS defines the output folder once, before creating the generated code. When the code we have to generate is just a TurboModule (TM) or a Fabric Component (FC), this mechanism works properly. However, if a library has to generate both TM and FC, actually using the library type `all`, all the code is generated using the TurboModules' output folder. (**Note:** Android only works in this way) This generates invalid code because all the FC's `#import` directives assumes that the code is generated in the FC output path which, in this case, is not. ## Solution The adopted solution moves the responsibility to decide where the files has to be generated to the CodeGen step instead of in the preparatory phases. The two paths are precomputed in the `generate-artifacts.js` script (the entry point for the CodeGen) and they are passed to all the scripts that requires them. Once they reach the `RNCodegen.js` file, the generators creates the files and save them in the proper paths. ## Changelog [iOS][Changed] - CodeGen now supports the `"all"` library type. Differential Revision: D35820848 fbshipit-source-id: e7abb0632caad16fa359e7b1b78ca7f7afd44b2a
Summary: This Diff splits the `generate-artifacts.js` script into: * `generate-artifacts-executor.js`: which contains the logic to generate the code for iOS. * `generate-artifacts.js`: which contains the argument parsing logic and invokes the executor. Finally, it introduces some tests. ## Changelog [iOS][Changed] - Refactor part of the codegen scripts and add tests. Differential Revision: D35846674 fbshipit-source-id: bd5d7ea46bfa32b345b8ef808d1ea499308089dc
added 2 commits
May 1, 2022 07:54
Summary: This Diff splits the `generate-specs-cli.js` script into: * `generate-specs-cli-executor.js`: which contains the logic to generate the code for iOS. * `generate-specs-cli.js`: which contains the argument parsing logic and invokes the executor. Finally it introduces some tests. ## Changelog [iOS][Changed] - Refactor part of the codegen scripts and add tests. Differential Revision: https://www.internalfb.com/diff/D35892576?entry_point=27 fbshipit-source-id: 17b63da3d81da6a9482ed6f5268e8f00191bd7b8
facebook#33729) Summary: Pull Request resolved: facebook#33729 This PR addresses [this comment](https://www.internalfb.com/diff/D35820848?dst_version_fbid=496290878846487&transaction_fbid=355967423221044). It makes the CodeGen to the `outputDir` as base directory for the codegen. Finally, it updates the unit tests accordingly. ## Changelog [iOS][Changed] - use `outputDir` as base directory for the codegen and remove the possibility to customize the intermediate path. The generated code requires specific paths in the `#include` directive. Reviewed By: cortinico, dmitryrykun Differential Revision: D35935282 fbshipit-source-id: 3fdfb0adaa28be10471fd13893433217a739fa1a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35935282 |
cipolleschi
force-pushed
the
export-D35935282
branch
from
978a714 to
49dae72
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 3, 2022
facebook#33729) Summary: Pull Request resolved: facebook#33729 This PR addresses [this comment](https://www.internalfb.com/diff/D35820848?dst_version_fbid=496290878846487&transaction_fbid=355967423221044). It makes the CodeGen to the `outputDir` as base directory for the codegen. Finally, it updates the unit tests accordingly. ## Changelog [iOS][Changed] - use `outputDir` as base directory for the codegen and remove the possibility to customize the intermediate path. The generated code requires specific paths in the `#include` directive. Differential Revision: D35935282 fbshipit-source-id: f9e0d29d987fdb4f88b37d540bf6e195798c95db
Collaborator
|
This pull request was successfully merged by @cipolleschi in e4d0153. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses this comment.
It makes the CodeGen to the
outputDiras base directory for the codegen.Finally, it updates the unit tests accordingly.
Changelog
[iOS][Changed] - use
outputDiras base directory for the codegen and remove the possibility to customize the intermediate path. The generated code requires specific paths in the#includedirective.Reviewed By: cortinico, dmitryrykun
Differential Revision: D35935282