Fix Circle CI for CompositeReactPackageTurboModuleManagerDelegate#33758
Closed
christophpurrer wants to merge 1 commit into
Closed
Fix Circle CI for CompositeReactPackageTurboModuleManagerDelegate#33758christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary:
This fails to compile in our CircleCI builds
```
/root/react-native/ReactAndroid/src/main/java/com/facebook/react/CompositeReactPackageTurboModuleManagerDelegate.java:52: error: incompatible types: java.util.List<java.lang.Object> cannot be converted to java.util.List<com.facebook.react.ReactPackage>
delegates.add(delegatesBuilder.build(context, Collections.emptyList()));
```
Make the empty collection generic should solve the issue
Changelog:
[Internal] [Changed] - Fix Circle CI for CompositeReactPackageTurboModuleManagerDelegate
Reviewed By: cortinico, dmitryrykun
Differential Revision: D36130573
fbshipit-source-id: bc821b40476036b96baf1df3d9629c5b15bb40d6
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36130573 |
Base commit: e7d9e4d |
Base commit: e7d9e4d |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2022
…3758) Summary: Pull Request resolved: #33758 This fails to compile in our CircleCI builds ``` /root/react-native/ReactAndroid/src/main/java/com/facebook/react/CompositeReactPackageTurboModuleManagerDelegate.java:52: error: incompatible types: java.util.List<java.lang.Object> cannot be converted to java.util.List<com.facebook.react.ReactPackage> delegates.add(delegatesBuilder.build(context, Collections.emptyList())); ``` Make the empty collection generic should solve the issue Changelog: [Internal] [Changed] - Fix Circle CI for CompositeReactPackageTurboModuleManagerDelegate Reviewed By: cortinico, dmitryrykun Differential Revision: D36130573 fbshipit-source-id: 9615311798fbbd7c000838dfbc043f450c2d9e2e
Collaborator
|
This pull request was successfully merged by @christophpurrer in 7d037dd. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This fails to compile in our CircleCI builds
Make the empty collection generic should solve the issue
Changelog:
[Internal] [Changed] - Fix Circle CI for CompositeReactPackageTurboModuleManagerDelegate
Reviewed By: cortinico, dmitryrykun
Differential Revision: D36130573