Handle possible null exception on ReactEditText with AppCompat 1.4.0#33769
Handle possible null exception on ReactEditText with AppCompat 1.4.0#33769mikemasam wants to merge 1 commit into
Conversation
This Change fixes a possible null exception as the user uses AppCompat 1.4.0 as a dependency in their App and uses a `TextInput` component. The exception may happen as `mFabricViewStateManager` is accessed during the constructor of the superclass, and is not yet initialized. - For reference, commit #e21f8ec34984551f87a306672160cc88e67e4793 fixes the crash which was already happening.
|
Hi @mikemasam! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Base commit: 018d5cf |
Base commit: 870755f |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
left a comment
There was a problem hiding this comment.
Thanks for sending this over @mikemasam
Related to #31572 for reference
|
This pull request was successfully merged by @mikemasam in 24a1f5c. When will my fix make it into a release? | Upcoming Releases |
This Change fixes a possible null exception as the user uses AppCompat 1.4.0
as a dependency in their App and uses a
TextInputcomponent.The exception may happen as
mFabricViewStateManageris accessed duringthe constructor of the superclass, and is not yet initialized.
Summary
Possible null exception as
mFabricViewStateManageris accessed duringthe constructor of the superclass, white it is not yet initialized.
This commit #e21f8ec34984551f87a306672160cc88e67e4793 fixes the crash which was already happening, accessing of mFabricViewStateManager before initialization, and left another one of the call of the same nature.
Changelog
Fix: accessing
mFabricViewStateManagerbefore initialization.[JavaScript] [Fixed] - accessing
mFabricViewStateManagerbefore initialization.Test Plan
no external tool was used.