Replace NativeRunnable with fbjni implementation#33776
Closed
javache wants to merge 2 commits into
Closed
Conversation
Differential Revision: D36200090 fbshipit-source-id: afd8c44ad4079996342145cd90d01ebfd0741db5
Summary: The implementations of these modules is pretty much identical, and we're already shipping the fbjni version of this anyway. Changelog: [Internal] Differential Revision: D36200330 fbshipit-source-id: 777e4e3e64288bcc128723939f36f997be7aecba
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36200330 |
Base commit: 09878c8 |
Collaborator
|
This pull request was successfully merged by @javache in 80f7367. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The implementations of these modules is pretty much identical, and we're already shipping the fbjni version of this anyway.
Changelog: [Internal]
Differential Revision: D36200330