Hermes: Use prepare-hermes-for-build in CocoaPods#33825
Closed
hramos wants to merge 3 commits into
Closed
Conversation
Differential Revision: D36329356 fbshipit-source-id: 6cf918642812d756c28880d75b5bfee8e9d07481
Summary: Adds a script that uses the new hermes-utils.js functions to prepare the local filesystem for Hermes to be built from source (e.g. download the Hermes source code tarball and extract it into its final location). Differential Revision: D36334624 fbshipit-source-id: 40a524cc20bfc643b337784d9b585e9b4473203a
Summary: Updates the CocoaPods build scripts to consume the prepare-hermes-for-build script, replacing the now redundant set of Ruby code that would previously set the filesystem up. Changelog: [iOS] [Changed] - When building Hermes from source, the filesystem will now be prepared using the new hermes-utils.js scripts, outside of CocoaPods Reviewed By: cortinico Differential Revision: D36336633 fbshipit-source-id: d953eb5f9a64c3a1f94e959f58e7369aceb69e8a
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36336633 |
Base commit: 58bc981 |
Base commit: 58bc981 |
Collaborator
|
This pull request was successfully merged by @hramos in aaa01f7. When will my fix make it into a release? | Upcoming Releases |
fortmarek
pushed a commit
that referenced
this pull request
May 20, 2022
Summary: Pull Request resolved: #33825 Updates the CocoaPods build scripts to consume the prepare-hermes-for-build script, replacing the now redundant set of Ruby code that would previously set the filesystem up. Changelog: [iOS] [Changed] - When building Hermes from source, the filesystem will now be prepared using the new hermes-utils.js scripts, outside of CocoaPods Reviewed By: cortinico Differential Revision: D36336633 fbshipit-source-id: a4506db80c039529b14b0290d2f0b54fae78dcf2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updates the CocoaPods build scripts to consume the prepare-hermes-for-build script, replacing the now redundant set of Ruby code that would previously set the filesystem up.
Changelog:
[iOS] [Changed] - When building Hermes from source, the filesystem will now be prepared using the new hermes-utils.js scripts, outside of CocoaPods
Reviewed By: cortinico
Differential Revision: D36336633