Skip to content

Setup a toplevel downloadAll task#33852

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D36441728
Closed

Setup a toplevel downloadAll task#33852
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D36441728

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
Similarly to buildAll and cleanAll, I'm creating a downloadlAll task
which is aligning the behavior of the download task we're doing on CIs.

I've also updated the Offline Cache as we're now storing a bigger set of dependencies.

Changelog:
[Internal] [Changed] - Setup a toplevel downloadAll task

allow-large-files

Reviewed By: cipolleschi

Differential Revision: D36441728

Summary:
Similarly to buildAll and cleanAll, I'm creating a downloadlAll task
which is aligning the behavior of the download task we're doing on CIs.

I've also updated the Offline Cache as we're now storing a bigger set of dependencies.

Changelog:
[Internal] [Changed] - Setup a toplevel downloadAll task

allow-large-files

Reviewed By: cipolleschi

Differential Revision: D36441728

fbshipit-source-id: 7ce071e36ffbc02a5d23c321b364774b3b292f29
@cortinico cortinico requested a review from hramos as a code owner May 17, 2022 16:35
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 17, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D36441728

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,777,148 +0
android hermes armeabi-v7a 7,181,103 +0
android hermes x86 8,087,169 +0
android hermes x86_64 8,066,215 +0
android jsc arm64-v8a 9,650,674 +0
android jsc armeabi-v7a 8,423,397 +0
android jsc x86 9,601,280 +0
android jsc x86_64 10,197,514 +0

Base commit: b331229
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b331229
Branch: main

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in afb0307.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants