Do not fail if -javadoc.jar are missing in the final NPM package#33869
Closed
cortinico wants to merge 1 commit into
Closed
Do not fail if -javadoc.jar are missing in the final NPM package#33869cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: When I disabled the Javadoc pubblication as it was failing on CI, I forgot to turn off the verification that the -javadoc artifact is included inside the NPM package. This caused `build_npm_package-1` to fail on main. I'm fixing it here. Changelog: [Internal] [Fixed] - Do not fail if -javadoc.jar are missing in the final NPM package Differential Revision: D36507320 fbshipit-source-id: 31743ed7f218677f56844697d82c2067ff36a1cd
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36507320 |
Base commit: e584fd1 |
Base commit: e584fd1 |
Collaborator
|
This pull request was successfully merged by @cortinico in c19bc0b. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When I disabled the Javadoc pubblication as it was failing on CI,
I forgot to turn off the verification that the -javadoc artifact is included
inside the NPM package. This caused
build_npm_package-1to fail on main.I'm fixing it here.
Changelog:
[Internal] [Fixed] - Do not fail if -javadoc.jar are missing in the final NPM package
Differential Revision: D36507320