Cleanup Folders after codegen#33891
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: This diff adds a function to clean up folders and empty files (if any) after the codegen runs in the OSS. To align how iOS and Android behave in the codegen, we now have to preemptively create folders that we may not need later. Thanks to this function, we recursively the folders in the codegen and we delete them if they are empty. ## Changelog [iOS][Added] - Add function to cleanup codegen folders Differential Revision: D36594999 fbshipit-source-id: 1ed0fcc13b2d38ffcae22ed69774219333be030f
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D36594999 |
react-native-bot
added
Platform: iOS
Base commit: 08ebc1c |
Base commit: 08ebc1c |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 7169288. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a function to clean up folders and empty files (if any) after the codegen runs in the OSS.
To align how iOS and Android behave in the codegen, we now have to preemptively create folders that we may not need later.
Thanks to this function, we recursively the folders in the codegen and we delete them if they are empty.
Changelog
[iOS][Added] - Add function to cleanup codegen folders
Differential Revision: D36594999