[Feat] Avoid installing Flipper in CI#33899
Conversation
Base commit: 8363184 |
ef1fe4d to
4c597eb
Compare
Base commit: 8363184 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Just a heads up that this would reduce our confidence on having Flipper working on the new app template. I'm not sure we want to do this.
On Android, we always include Flipper regardless of CI.
I can understand the win on build time for a RN user, but as we're testing the default template here, it probably makes sense to make sure Flipper is also included in the build
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This PR speeds up the build in CircleCI by avoiding adding Flipper dependency when running in CI. The savings are: * ~ 13/15% for `test_ios` * ~ 30/40% for `test_rntester` * ~50% for `test_ios_template`~ **Edit after review**: We do actually want to have Flipper in the `test_ios_template` to check that it builds correctly. ## Changelog [iOS] [Changed] - Do not add Flipper when running in CI. Pull Request resolved: facebook#33899 Test Plan: CircleCI passing with these stats: | BEFORE | AFTER | | ---- | ---- | | <img width="663" alt="FlipperCI-Before" src="https://user-images.githubusercontent.com/11162307/170006493-2651b000-0421-47c3-90e9-153474c15a95.png"> | <img width="652" alt="FlipperCI-After" src="https://user-images.githubusercontent.com/11162307/170006557-34e53601-66b4-4054-a156-0e2349f48dc2.png"> | Reviewed By: cortinico Differential Revision: D36625117 Pulled By: cipolleschi fbshipit-source-id: 2bc8dc9e3d8f4b53d74379443f42a68933f63ab5
|
This pull request was exported from Phabricator. Differential Revision: D36625117 |
5528717 to
82217c7
Compare
|
This pull request was successfully merged by @cipolleschi in ad76eb3. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR speeds up the build in CircleCI by avoiding adding Flipper dependency when running in CI.
The savings are:
test_iostest_rntester50% fortest_ios_templateEdit after review: We do actually want to have Flipper in the
test_ios_templateto check that it builds correctly.Changelog
[iOS] [Changed] - Do not add Flipper when running in CI.
Test Plan
CircleCI passing with these stats: