Attempt to fix test_android by adding a react-native.config.js inside rn-tester#33901
Closed
cortinico wants to merge 1 commit into
Closed
Attempt to fix test_android by adding a react-native.config.js inside rn-tester#33901cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
6715f17 to
3bee5b3
Compare
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 406a474 |
Base commit: 406a474 |
Collaborator
|
This pull request was successfully merged by @cortinico in 1ee7a0a. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_androidis now red because I had to specify a root for RN tester.The job is now failing as it fails to find the correct platforms for the bundler command.
This PR fixes it.
Changelog
[Internal] - Attempt to fix test_android by moving react-native.config.js
Test Plan
Tested locally + will wait for a CI result