Skip to content

Attempt to fix test_android by adding a react-native.config.js inside rn-tester#33901

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:nc/rn-tester-config-file
Closed

Attempt to fix test_android by adding a react-native.config.js inside rn-tester#33901
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:nc/rn-tester-config-file

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary

test_android is now red because I had to specify a root for RN tester.
The job is now failing as it fails to find the correct platforms for the bundler command.
This PR fixes it.

Changelog

[Internal] - Attempt to fix test_android by moving react-native.config.js

Test Plan

Tested locally + will wait for a CI result

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 24, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico cortinico force-pushed the nc/rn-tester-config-file branch from 6715f17 to 3bee5b3 Compare May 24, 2022 11:56
@cortinico cortinico changed the title Attempt to fix test_android by moving react-native.config.js Attempt to fix test_android by adding a react-native.config.js inside rn-tester May 24, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,782,661 +18
android hermes armeabi-v7a 7,186,066 +6
android hermes x86 8,094,112 +7
android hermes x86_64 8,071,786 -4
android jsc arm64-v8a 9,656,072 +7
android jsc armeabi-v7a 8,428,329 +9
android jsc x86 9,608,310 +5
android jsc x86_64 10,202,934 -4

Base commit: 406a474
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 406a474
Branch: main

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 1ee7a0a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants