Skip to content

🔥 (FileReader) remove unused _subscriptions attribute#33946

Closed
AntoineDoubovetzky wants to merge 1 commit into
facebook:mainfrom
AntoineDoubovetzky:remove-unused-code-in-FileReader
Closed

🔥 (FileReader) remove unused _subscriptions attribute#33946
AntoineDoubovetzky wants to merge 1 commit into
facebook:mainfrom
AntoineDoubovetzky:remove-unused-code-in-FileReader

Conversation

@AntoineDoubovetzky
Copy link
Copy Markdown

Summary

I was reading source code, and I noticed the _subscriptions attribute (and the _clearSubscriptions method) of the FileReader is not used.

Changelog

[Internal] [Changed] - Remove unused _subscriptions attribute in FileReader

Test Plan

I checked that flow and jest are still green as I can't think about another way.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 1, 2022
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,788,127 -33
android hermes armeabi-v7a 7,191,702 -40
android hermes x86 8,099,477 -47
android hermes x86_64 8,076,985 -36
android jsc arm64-v8a 9,656,265 +0
android jsc armeabi-v7a 8,428,769 +1
android jsc x86 9,608,438 +3
android jsc x86_64 10,202,981 -12

Base commit: f1775ba
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f1775ba
Branch: main

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @AntoineDoubovetzky in dbcada0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants