Move New Architecture setup to new_architecture.rb file#33990
Closed
cipolleschi wants to merge 1 commit into
Closed
Move New Architecture setup to new_architecture.rb file#33990cipolleschi wants to merge 1 commit into
new_architecture.rb file#33990cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37040927 |
Base commit: 168f020 |
Base commit: 71da212 |
…3990) Summary: Pull Request resolved: facebook#33990 This diff moves the setting of some CPP flags from the main React native pods file to a dedicated file. It also introduces some tests and it improves the Test Mocks we have ## Changelog [iOS][Changed] - Move the `modify_flags_for_new_architecture` method to separate ruby file Reviewed By: cortinico Differential Revision: D37040927 fbshipit-source-id: 20fab8bd95f25c05b1fc66b6d507114783ff70b1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37040927 |
cipolleschi
force-pushed
the
export-D37040927
branch
from
360cf0f to
2e60389
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in 71da212. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves the setting of some CPP flags from the main React native pods file to a dedicated file.
It also introduces some tests and it improves the Test Mocks we have
Changelog
[iOS][Changed] - Move the
modify_flags_for_new_architecturemethod to separate ruby fileDifferential Revision: D37040927