Make Hermes the default engine on iOS#34085
Closed
hramos wants to merge 1 commit into
Closed
Conversation
Summary: Hermes is now the default engine on iOS. Apps can choose to continue using JSC by setting `hermes_enabled` to `false` in their Podfile. The RNTester app now uses Hermes, as well. Use JSC in RNTester by setting `USE_HERMES=0` when running `pod install`. Changelog: [iOS][Changed] Hermes is now the default engine on iOS. This setting is controlled via `flags[:hermes_enabled]` in the Podfile. Reviewed By: cortinico, cipolleschi Differential Revision: D37361468 fbshipit-source-id: 1644977176120f0b1abffb8cda538b42b109c840
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37361468 |
Base commit: cf0a0ef |
Base commit: cf0a0ef |
Collaborator
|
This pull request was successfully merged by @hramos in 1115bc7. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Hermes is now the default engine on iOS.
Apps can choose to continue using JSC by setting
hermes_enabledtofalsein their Podfile.The RNTester app now uses Hermes, as well. Use JSC in RNTester by setting
USE_HERMES=0when runningpod install.Changelog:
[iOS][Changed] Hermes is now the default engine on iOS. This setting is controlled via
flags[:hermes_enabled]in the Podfile.Reviewed By: cortinico, cipolleschi
Differential Revision: D37361468