Use NODE_BINARY from .xcode.env when running packager from Xcode

[elsurudo]

Summary

Before this change, during the "Start Packager" Xcode build step that runs the packager, packager.sh was using my system node version and not the one from nvm that is meant to be used with the project.

Changelog

[iOS] [Fixed] - Use NODE_BINARY from .xcode.env when running packager from Xcode

Test Plan

Perform a build using Xcode and confirm that the packager is using the correct version of node.

[facebook-github-bot]

Hi @elsurudo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,821,558	+0
android	hermes	armeabi-v7a	7,214,646	+0
android	hermes	x86	8,135,405	+0
android	hermes	x86_64	8,113,182	+0
android	jsc	arm64-v8a	9,697,835	+0
android	jsc	armeabi-v7a	8,452,903	+0
android	jsc	x86	9,648,521	+0
android	jsc	x86_64	10,246,427	+0

Base commit: bb46046
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: bb46046
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Hi @elsurudo, thanks for the PR. Can I ask you to rebase it on the latest commit on main?
There is a job that is red and it could be related to something that we did last week. Probably a rebase will fix it. If that the case, I'll proceed merging the PR!

Thank you so much for your patience!

[elsurudo]

@cipolleschi rebased – you're good to go :)

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @elsurudo in ff785db.

^{When will my fix make it into a release? | Upcoming Releases}