Simplify logic to choose if we need to build hermes from source or not.#34232
Closed
cipolleschi wants to merge 1 commit into
Closed
Simplify logic to choose if we need to build hermes from source or not.#34232cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37999748 |
…t. (facebook#34232) Summary: Pull Request resolved: facebook#34232 This diff simplify the logic to decide whether we want to build hermes from source or not. The requirement we have is that we don't want our users to build hermes. So, we don't want to build hermes when there is a precompiled tarball available, while we want to build hermes in CI. ## Changelog [General][Changed] - Build hermes when in CI and not when there is a tarball Differential Revision: D37999748 fbshipit-source-id: 610377cf9057caf0e661aaf96eeb5cce4e27ee78
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37999748 |
cipolleschi
force-pushed
the
export-D37999748
branch
from
c488c58 to
6bd2e77
Compare
Base commit: 9923ac1 |
Base commit: 9923ac1 |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 4b51207. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff simplify the logic to decide whether we want to build hermes from source or not.
The requirement we have is that we don't want our users to build hermes.
So, we don't want to build hermes when there is a precompiled tarball available, while we want to build hermes in CI.
Changelog
[General][Changed] - Build hermes when in CI and not when there is a tarball
Differential Revision: D37999748