Skip to content

[CI] Run ESLint in Danger#34305

Closed
cipolleschi wants to merge 3 commits intomainfrom
feat/add-meta-linters
Closed

[CI] Run ESLint in Danger#34305
cipolleschi wants to merge 3 commits intomainfrom
feat/add-meta-linters

Conversation

@cipolleschi
Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi commented Jul 29, 2022

Summary

This PR runs eslint in PR using Danger.

Changelog

[General] [Changed] - Run ESLint in CI

Test Plan

  1. Add a JS lint error in the package/react-native-codegen package.
  2. Observe the CI task post a message with the errors
  3. Fix the errors
  4. Observe the CI task report completion with no errors

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 29, 2022
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 29, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9797388
Branch: main

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 29, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,831,789 +35
android hermes armeabi-v7a 7,222,819 +31
android hermes x86 8,143,530 +55
android hermes x86_64 8,122,983 +19
android jsc arm64-v8a 9,711,280 +27
android jsc armeabi-v7a 8,464,543 +26
android jsc x86 9,660,759 +31
android jsc x86_64 10,260,055 +20

Base commit: a53512f
Branch: main

@cipolleschi cipolleschi force-pushed the feat/add-meta-linters branch 25 times, most recently from 1ce6a69 to 9706373 Compare August 1, 2022 11:05
@cipolleschi cipolleschi force-pushed the feat/add-meta-linters branch 6 times, most recently from bf5895f to f494b68 Compare August 1, 2022 14:47
@cipolleschi cipolleschi changed the title test: linters [CI] Run ESLint in Danger Aug 1, 2022
@cipolleschi cipolleschi marked this pull request as ready for review August 1, 2022 14:50
@cipolleschi cipolleschi requested a review from hramos as a code owner August 1, 2022 14:50
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the feat/add-meta-linters branch 2 times, most recently from 4d39f15 to 71fd457 Compare August 1, 2022 16:06
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Riccardo Cipolleschi added 2 commits August 2, 2022 09:55
@cipolleschi cipolleschi force-pushed the feat/add-meta-linters branch 11 times, most recently from 224cc30 to 4696ffb Compare August 2, 2022 09:25
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 1bba590.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants