Simplify TurboModule setup#34373
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38509891 |
Base commit: e509f96 |
Base commit: e509f96 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38509891 |
cipolleschi
force-pushed
the
export-D38509891
branch
from
ed3c29a to
a38348f
Compare
Summary: Pull Request resolved: facebook#34373 By introducing a RCTAppDelegate base class, we can simplify the migration step to supports TM ## Changelog [iOS][Changed] - Simplified migration steps for TM Reviewed By: cortinico Differential Revision: D38509891 fbshipit-source-id: 3013cc1aec3035996dd5ad92bf20d83541dd8173
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38509891 |
cipolleschi
force-pushed
the
export-D38509891
branch
from
a38348f to
f94a417
Compare
Contributor
|
@cipolleschi If we have a base class now, would it make sense to extract all the other methods and vars out as well? That would result in a much smaller app delegate. |
Contributor
Author
|
@danilobuerger Yes, but I wanted to tackle in another PR not to have too big changes and to clearly separate TM and FC |
Contributor
|
Awesome! |
Collaborator
|
This pull request was successfully merged by @cipolleschi in cb02a6e. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Pull Request resolved: facebook#34373 By introducing a RCTAppDelegate base class, we can simplify the migration step to supports TM ## Changelog [iOS][Changed] - Simplified migration steps for TM Reviewed By: cortinico Differential Revision: D38509891 fbshipit-source-id: 716c1e668a05ecbd9c679558889564780816e491
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
Summary: So we can test the feature. DiffTrain build for [3168e08f8389d258de9eb7c8d19b9d44a0f250f2](facebook/react@3168e08) Reviewed By: kassens Differential Revision: D81599263 fbshipit-source-id: a33ca01250206a2a35350f7fad09e43071522df7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
By introducing a RCTAppDelegate base class, we can simplify the migration step to supports TM
Changelog
[iOS][Changed] - Simplified migration steps for TM
Differential Revision: D38509891